search

casacore / python-casacore

Python bindings for casacore, a library used in radio astronomy
http://casacore.github.io/python-casacore
GNU Lesser General Public License v3.0
35 stars 22 forks source link

Add casacore data files to package #260

Closed gmloose closed 9 months ago

gmloose commented 9 months ago

This PR ensures that the casacore data files (ephemerides and geodetic) are added to the generated source and binary distribution, and that they can be found at runtime.

To test the latter, you can use the following command, which should succeed:

python -c "from casacore.tables import taql; taql('calc meas.azel(\"Jupiter\",2016-06-28 19:54,\"DWL\") deg')"
pep8speaks commented 9 months ago

Hello @gmloose! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 278:80: E501 line too long (112 > 79 characters) Line 297:80: E501 line too long (86 > 79 characters) Line 299:80: E501 line too long (80 > 79 characters) Line 300:80: E501 line too long (84 > 79 characters) Line 301:80: E501 line too long (87 > 79 characters) Line 302:80: E501 line too long (85 > 79 characters) Line 303:80: E501 line too long (85 > 79 characters) Line 304:80: E501 line too long (83 > 79 characters) Line 307:80: E501 line too long (88 > 79 characters)

Comment last updated at 2024-02-29 12:26:56 UTC
gmloose commented 9 months ago

Could you document the behavior of the symlink?

Done. See https://github.com/casacore/python-casacore/pull/260/commits/6f1ac4a9eb379bc0934e6aaaa40d29c1847d6e65