search

casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
192 stars 71 forks source link

addressed #321 #368

Closed kennethshsu closed 2 years ago

kennethshsu commented 2 years ago

Addressed #321, problem was in the trend_array near line 159.

jbogaardt commented 2 years ago

This PR seems to break a few existing unit tests.

jbogaardt commented 2 years ago

Interestingly, there is one unrelated failure. It seems to be from a recent update to pandas==1.5.1 used by github actions. Since it's unrelated, I'll merge, but will need to address the pandas issue soon.

kennethshsu commented 2 years ago

I saw that too since I didn't get an error locally, I'll take a look shortly.