casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
192 stars 71 forks source link

consolidating weighted regression factor fit #398

Closed henrydingliu closed 1 year ago

henrydingliu commented 1 year ago

start of some consolidation/standardization effort between Development and IncrementalAdditive, with the eventual goal of generalizing tails and BF that handles additive factors.

codecov-commenter commented 1 year ago

Codecov Report

Base: 83.87% // Head: 83.97% // Increases project coverage by +0.10% :tada:

Coverage data is based on head (b9cd358) compared to base (ee23f8a). Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #398 +/- ## ========================================== + Coverage 83.87% 83.97% +0.10% ========================================== Files 49 49 Lines 4377 4386 +9 Branches 725 724 -1 ========================================== + Hits 3671 3683 +12 + Misses 505 504 -1 + Partials 201 199 -2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `83.97% <94.11%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/casact/chainladder-python/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [chainladder/development/incremental.py](https://codecov.io/gh/casact/chainladder-python/pull/398/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvZGV2ZWxvcG1lbnQvaW5jcmVtZW50YWwucHk=) | `86.30% <88.88%> (+4.35%)` | :arrow_up: | | [chainladder/development/base.py](https://codecov.io/gh/casact/chainladder-python/pull/398/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvZGV2ZWxvcG1lbnQvYmFzZS5weQ==) | `95.55% <100.00%> (+0.13%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.