casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
192 stars 71 forks source link

Expanded mappings to include semester sampling #403

Closed A108669 closed 1 year ago

A108669 commented 1 year ago

Closes #402

codecov-commenter commented 1 year ago

Codecov Report

Base: 83.98% // Head: 83.98% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (708f4b7) compared to base (7342bbe). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #403 +/- ## ========================================== - Coverage 83.98% 83.98% -0.01% ========================================== Files 49 49 Lines 4415 4414 -1 Branches 728 728 ========================================== - Hits 3708 3707 -1 Misses 505 505 Partials 202 202 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `83.98% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/casact/chainladder-python/pull/403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [chainladder/adjustments/bootstrap.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvYWRqdXN0bWVudHMvYm9vdHN0cmFwLnB5) | `88.72% <ø> (-0.09%)` | :arrow_down: | | [chainladder/tails/bondy.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvdGFpbHMvYm9uZHkucHk=) | `90.00% <ø> (ø)` | | | [chainladder/development/base.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvZGV2ZWxvcG1lbnQvYmFzZS5weQ==) | `95.55% <100.00%> (ø)` | | | [chainladder/development/clark.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvZGV2ZWxvcG1lbnQvY2xhcmsucHk=) | `91.11% <100.00%> (ø)` | | | [chainladder/tails/clark.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvdGFpbHMvY2xhcmsucHk=) | `86.66% <100.00%> (ø)` | | | [chainladder/tails/curve.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvdGFpbHMvY3VydmUucHk=) | `58.69% <100.00%> (ø)` | | | [chainladder/utils/utility\_functions.py](https://codecov.io/gh/casact/chainladder-python/pull/403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvdXRpbHMvdXRpbGl0eV9mdW5jdGlvbnMucHk=) | `82.55% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jbogaardt commented 1 year ago

Thank you @A108669!..Especially for finding all the places where we missed the semester grain! I really appreciate the contribution. It will be available in the next chainladder release..

A108669 commented 1 year ago

Thank you Matt Graziano!..Especially for finding all the places where we missed the semester grain! I really appreciate the contribution. It will be available in the next chainladder release..

No problem! I'm happy I could help