search

casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
192 stars 71 forks source link

Addressed #420 and #491 #507

Closed kennethshsu closed 7 months ago

kennethshsu commented 7 months ago
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.62%. Comparing base (583760a) to head (b88308d).

Files Patch % Lines
chainladder/core/display.py 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #507 +/- ## ========================================== + Coverage 80.57% 80.62% +0.05% ========================================== Files 80 80 Lines 4735 4739 +4 Branches 808 808 ========================================== + Hits 3815 3821 +6 + Misses 643 642 -1 + Partials 277 276 -1 ``` | [Flag](https://app.codecov.io/gh/casact/chainladder-python/pull/507/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=casact) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/casact/chainladder-python/pull/507/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=casact) | `80.62% <40.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=casact#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jbogaardt commented 7 months ago

I'm surprised we have polars in the dev environment. I've been experimenting with it in lieu of sparse, but haven't hit a point where it should be in the main branch.

kennethshsu commented 7 months ago

polars was already there I think, I only added the newer cpu version of it.

From the very limited few hours that I spent messing with it, I like it a lot and prefer it over sparse too.