search

casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
192 stars 71 forks source link

[ENH] Suggestion: Alternative parameter name for format argument in _to_datetime method #526

Open genedan opened 6 months ago

genedan commented 6 months ago

In the TriangleBase class there is a method called _to_datetime that has an argument called format:

@staticmethod
def _to_datetime(data, fields, period_end=False, format=None):

I'm getting a warning from my IDE that format shadows a built-in name in Python. I propose that we rename it to something else, maybe datetime_format.