search

casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
178 stars 69 forks source link

sklearn update to _fit_single_estimator #528

Open ohsosunny opened 1 month ago

ohsosunny commented 1 month ago

https://github.com/casact/chainladder-python/blob/7e5dd10bc08b5b4d738ec35b14d0c8b85b206bc2/chainladder/workflow/voting.py#L127

sklearn update in https://github.com/scikit-learn/scikit-learn/blob/7398114752a056edffb6c768393e61c32d56a6c6/sklearn/ensemble/_base.py#L21C22-L21C32 no longer has sample_weight as parameter. It needs fit_params instead.

kennethshsu commented 1 month ago

Hi @ohsosunny, are you proposing that we change the name of the variable from sample_weight to fit_params? Do you think sample_weight is an inappropriate use in the package? Why?

ohsosunny commented 3 weeks ago

Oh! Yes, the commit in https://github.com/scikit-learn/scikit-learn/commit/77a63e74350c78759cf7b8c0a2e81673fa437ed6 for sklearn _fit_single_estimator updated sample_weight with fit_params. chainladder-python/chainladder/workflow/voting.py needs to pass in fit_params