casadoj / lisflood-reservoirs

An analysis of possible improvements in the reservoir representation in the hydrological model LISFLOOD Open Source.
GNU General Public License v3.0
0 stars 0 forks source link

mHM routine: Vmin <= Vn #8

Closed casadoj closed 2 months ago

casadoj commented 2 months ago

The calibration of the mHM routine produces in some instances reservoirs whose minimum storage ($V_{min}$) is larger than the normal storage ($V_n$), which is nonesense.

This error is produced by the definition of $Vn$ as a factor of $V{tot}$, where $\gamma$ is a calibration parameter with a search range from 0 to 1:

$$Vn = \gamma \cdot V{tot}$$

In the current implementation, I fix $V_{min}$ to the minimum storage in the calibration period. That means that it is never checked that $Vn$ must be equal or larger than $V{min}$.

casadoj commented 2 months ago

Close #8

I have modified the __init__ method in the class mHM to update $V_{min}$ depending on $\gamma$.

Vmin = min(Vmin, gamma * Vtot)