casangi / astroviper

Radio Interferometry Data Processing
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Enable parallel image writes to S3 #18

Closed Jan-Willem closed 3 months ago

Jan-Willem commented 5 months ago

Currently, parallel image writes are done as follows:

This should be changed to make use of Zarr functionality so that parallel writes S3 are supported.

amcnicho commented 4 months ago

As of 6fcad36a42ca8acf16f512c408e8e4e750c6e7fa there is a new file tests/domain/imaging/test_cube_imaging_niter0.py that does basic integrity checks of image writes to disk. The branch also contains the changes I found necessary in order to get the new tests to pass with the most recent version of the Antennae dataset (i.e., for cube_imaging_niter0 not to raise exceptions when trying to write an image following the mosaic notebook).

I'll use these tests as the basis for switching write_chunk to use zarr.open, so @Jan-Willem it would help if you ran them to confirm the output still looks like you'd expect after the recent schema changes.