search

casangi / xradio

Xarray Radio Astronomy Data IO
Other
9 stars 5 forks source link

Work around missing np.float128 and np.complex256 #105

Closed tammojan closed 7 months ago

tammojan commented 7 months ago

Apparently Mac M1 does not have these types (probably because it's a 64-bit system).

For reference I'm running on mac M1, python 3.12, numpy 1.26.3.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

dmehring commented 7 months ago

I added all these types for completeness. I do not have use cases in mind for these large precisions. So, we can remove them I suppose, but in the case in 10 or 20 years there is a need for them, having them will make things work transparently without the need for a developer two or three generations removed from me to figure out what I did 20 years prior to decode np types from zarr images :) .

tammojan commented 7 months ago

I've now removed the two extra types, is that ok with you as well?

dmehring commented 7 months ago

Yes that's fine. Thanks