casangi / xradio

Xarray Radio Astronomy Data IO
Other
9 stars 5 forks source link

load_processing_set does not load weather_xds #136

Closed FedeMPouzols closed 1 month ago

FedeMPouzols commented 4 months ago

When the weather_xds was introduced, it was not properly added to the load_processing_set() function. This should be simple to fix:

diff --git a/src/xradio/vis/load_processing_set.py b/src/xradio/vis/load_processing_set.py
index a077c1e..842c1e0 100644
--- a/src/xradio/vis/load_processing_set.py
+++ b/src/xradio/vis/load_processing_set.py
@@ -82,11 +82,11 @@ def _load_ms_xds_core(ms_xds_name, slice_dict):
     optional_sub_xds = {
         "weather_xds": "WEATHER",
     }
-    for sub_xds_key, sub_xds_name in sub_xds.items():
-        sub_xds_path = os.path.join(ms_xds_name, sub_xds_name)
-        if os.path.isdir(sub_xds_path):
-            ms_xds.attrs[sub_xds_key] = _load_no_dask_zarr(
-                zarr_name=os.path.join(ms_xds_name, sub_xds_name)
+    for opt_xds_key, opt_xds_name in optional_sub_xds.items():
+        opt_xds_path = os.path.join(ms_xds_name, opt_xds_name)
+        if os.path.isdir(opt_xds_path):
+            ms_xds.attrs[opt_xds_key] = _load_no_dask_zarr(
+                zarr_name=os.path.join(ms_xds_name, opt_xds_name)
             )

     return ms_xds

read_processing_set() seems to load weather correctly.

FedeMPouzols commented 1 month ago

This is no longer an issue, as it is now fixed in read_processing_set.py:_read_sub_xds().