Closed FedeMPouzols closed 1 month ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: Jan-Willem
:x: FedeMPouzols
You have signed the CLA already but the status is still pending? Let us recheck it.
The failure is harmless in principle I think. Here is an attempt to fix the test without removing it.
The failure is a manifestation of https://github.com/numpy/numpy/issues/21166 "Conversion of numpy.nan to int gives inconsistent results" causing different behavior between platforms, for example: https://github.com/aai-institute/pyDVL/issues/474
This discrepancy should not be a big deal but could bite us if we end up having integer data variables in the final schema. For example missing "time-baseline" rows in the MS, become "np.nan" values in xdss, with the caveat that for integer data variables they would get whatever special value an np.nan is converted to. It turns out that:
but on mac (M1 it seems), nan converted to int => 0 Those 0s could cause ambiguities, but I'd hope that the changes in the xradio schema with respect to the cngi-io schema will remove most if not all those potential ambiguities (especially with ID variables).
Note well: