Fix warnings triggered in vis tests

casangi / xradio

Xarray Radio Astronomy Data IO

Other

9 stars 5 forks source link

Fix warnings triggered in vis tests #178

Closed FedeMPouzols closed 1 month ago

FedeMPouzols commented 1 month ago

Fixes warnings triggered in vis unit tests.

Most of the warnings had to do with casts or with deprecated operations on pandas indices.

Note well:

This contribution is made under the current ALMA software agreements.
(c) European Southern Observatory, 2024
Copyright by ESO (in the framework of the ALMA collaboration)

CLAassistant commented 1 month ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

FedeMPouzols commented 1 month ago

If we want to keep the code as free of warnings as possible, one options to consider is to turn warnings in pytest runs into errors, adding -Werror to the pytest command line here: https://github.com/casangi/xradio/blob/main/.github/workflows/python-testing-linux.yml / https://github.com/casangi/xradio/blob/main/.github/workflows/python-testing-macos.yml