Open v-morello opened 4 weeks ago
I had a look at the code and the core problem is that MeasurementSetXds.sel()
does two things instead of one:
Dataset.sel()
Suggested solution: get rid of that specialized sel()
, instead there should be a select_data_group()
method that does only that, and that can be chained independently with Dataset.sel()
. Both of these calls should then work:
xds.select_data_group("corrected").sel({"polarization": ["XX", "YY"]})
xds.sel({"polarization": ["XX", "YY"]}).select_data_group("corrected")
Helllo there,
I upgraded to v0.0.42 today, and I was surprised that the following code snippet does not work anymore on a MeasurementSetXds:
yields:
The reason is that I think I am calling Dataset.sel, but xradio forces me to call
MeasurementSetXds.sel()
which has a different interface and use case:I assume this is accidental, but anyway this method needs to have a different name, overriding any of the fundamental
Dataset
methods is not something we can afford in general.