Enable pre commit/push hook to improve project consistency

casavo / habitat

Casavo Design System Library

https://casavo.github.io/habitat/

Apache License 2.0

3 stars 0 forks source link

Enable pre commit/push hook to improve project consistency #67

Open GiovanniVisentiniCasavo opened 4 months ago

GiovanniVisentiniCasavo commented 4 months ago

Hi,

I'm used to have a the lint running on pre commit, to be secure to commit always formatted code, and to have the test and type check running on pre push.

what do you think? can we add this type of hooks also to this project?

pietrograndi commented 4 months ago

Hi @GiovanniVisentiniCasavo, I'm totally open to this idea. Do you think it would be enough to have a linting and prettifying phase on commit, and a TypeScript check along with unit tests on push?

GiovanniVisentiniCasavo commented 4 months ago

I'm used to have lint + type check on pre commit and test on pre push.. but we can move the type check also on pre push..