casbin-net / casbin-aspnetcore

Casbin.NET integration middleware and sample code for ASP.NET Core
https://github.com/casbin/Casbin.NET
Apache License 2.0
64 stars 20 forks source link

feat: Add DefaultAuthenticationSchemes option #22

Closed sagilio closed 3 years ago

sagilio commented 3 years ago

Fixes #21

sagilio commented 3 years ago

@thoraj Could you review this PR?

thoraj commented 3 years ago

I'm not sure I have enough knowledge about how casbin-aspnetcore is architected, or the underlying frameworks, to provide any feedback of value by just inspected the code.

I think perhaps the best way I can contribute is to test if, and how, changes will work in our project. Is there a way I can consume a package with these changes?

hsluoyz commented 3 years ago

@Sagilio plz make a release so @thoraj can help on testing it.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 0.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: