search

casbin-net / casbin-aspnetcore

Casbin.NET integration middleware and sample code for ASP.NET Core
https://github.com/casbin/Casbin.NET
Apache License 2.0
64 stars 20 forks source link

Typo in sample basic_policy.csv: Get or GET? #26

Closed LeiYangGH closed 3 years ago

LeiYangGH commented 3 years ago

I cloned and ran the sample. After some experiments, I found that in basic_policy.csv, GET works but Get not work.

  1. I searched and found this issue Case Insensitive Policy Enforcement, and it means casbin is case sensitive. so i assue this sample has a minor typo.
  2. I searched the entire library code, didn't find any hardcoded action string of GET or POST, etc. Could you please explain a little why in policy.csv the action syntax must be all upper case? Is it related to some http specification? Is it implement dependent(is the behaviour related to operation system/browser versions)?
hsluoyz commented 3 years ago

@Sagilio

sagilio commented 3 years ago

@hsluoyz Maybe same to issue #25