search

casbin-rs / actix-casbin-auth

Casbin Actix-web access control middleware
https://github.com/casbin/casbin-rs
55 stars 15 forks source link

Update README #26

Closed 0xethsign closed 3 years ago

0xethsign commented 3 years ago

This will avoid async runtime multiple importing issues.

Fix: https://github.com/casbin-rs/actix-casbin-auth/issues/25

hsluoyz commented 3 years ago

@hackerchai please review. Also can you help see why the CI failed?

image

codecov-io commented 3 years ago

Codecov Report

Merging #26 (db51640) into master (d381180) will increase coverage by 0.40%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   80.71%   81.11%   +0.40%     
==========================================
  Files           4        4              
  Lines         140      143       +3     
==========================================
+ Hits          113      116       +3     
  Misses         27       27
Impacted Files Coverage Δ
tests/test_set_enforcer.rs 93.54% <0.00%> (+0.21%) :arrow_up:
tests/test_middleware.rs 93.33% <0.00%> (+0.22%) :arrow_up:
tests/test_middleware_domain.rs 92.85% <0.00%> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d381180...db51640. Read the comment docs.

0xethsign commented 3 years ago

I think this works now.

0xethsign commented 3 years ago

I think #25 can be closed now