Contributions are welcome

casbin / Casbin.NET

An authorization library that supports access control models like ACL, RBAC, ABAC in .NET (C#)

https://casbin.org

Apache License 2.0

1.18k stars 112 forks source link

Contributions are welcome #1

Closed hsluoyz closed 4 years ago

hsluoyz commented 5 years ago

Currently, we have some unofficial implementations for C#. And maybe it's time to have an official one. I'm not sure if this code base is the best one, but suggestions are always welcome.

@xgenvn, can you help contribute to it?

@huazhikui, can you provide a to-do list?

hsluoyz commented 5 years ago

After discussing with @huazhikui , the current status for this project is: has the same functionality with jCasbin: https://github.com/casbin/jcasbin, test cases are also included.

TO-DOs:

Badges in README.md, including Travis CI, code coverage, Nuget, auto-generated docs (if any), code format, Gitter:

xgenvn commented 5 years ago

@hsluoyz Already fork the project, can't wait to have some time investing on first PR ;).

huazhikui commented 5 years ago

@xgenvn @hsluoyz TO-DO list:

Util.LogPrint() method
CoreEnforcer.SetWatcher method and Implementation class of IWatcher interface;

hsluoyz commented 5 years ago

Hi @xgenvn , can you help fix the code coverage badge in README? https://github.com/casbin-net/Casbin.NET#casbinnet

xgenvn commented 5 years ago

Hi @xgenvn , can you help fix the code coverage badge in README? https://github.com/casbin-net/Casbin.NET#casbinnet

I will take a look.

xgenvn commented 5 years ago

Have to move workplace recently so no actual work on the badge yet. I have tried to configure the current package (coveralls.net) plus opencover, then have some issues with local libraries not found. Will take a look at other libraries how they do this. Sorry for the late response.

hsluoyz commented 5 years ago

Hi @xgenvn , never mind. Thanks to @huazhikui, he had just made the badges work today :)