casbin-bot
commented
2 years ago @sagilio @xcaptain @huazhikui please review
Closed Leonardo-Ferreira closed 2 years ago
casbin-bot
commented
2 years ago @sagilio @xcaptain @huazhikui please review
hsluoyz
commented
2 years ago @Leonardo-Ferreira is there some kind of badge for it? Can you add it also in README in this PR?
hsluoyz
commented
2 years ago @Leonardo-Ferreira plz fix:
hsluoyz
commented
2 years ago @sagilio plz reivew
Leonardo-Ferreira
commented
2 years ago @Leonardo-Ferreira plz fix:
The error there is a "blank" secret and I actually can't fix it because the PR is not allowed to read GitHub secrets! once it's merged, it will. My repo has sech secrets and you can see at the bottom of https://sonarcloud.io/project/overview?id=Leonardo-Ferreira_Casbin.NET that the commit that triggered the analysis is this last one here:
Leonardo-Ferreira
commented
2 years ago @Leonardo-Ferreira is there some kind of badge for it? Can you add it also in README in this PR?
There is and I can, but I rather not do it right now because we have not defined the quality gates for the repo (which can be done only after the first analysis and computed after the at least the second). Not doing so might display an incorrect "red/failed" badge. I'd rather define these gates with you guys as a second activity which would culminate with the badge and the updated README. What you think?
hsluoyz
commented
2 years ago OK
github-actions[bot]
commented
2 years ago :tada: This PR is included in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Fix: https://github.com/casbin/Casbin.NET/issues/220
Created the sonar.yml, which builds, tests and analyses the solution using sonarcloud.
The reports will be accessible at https://sonarcloud.io/organizations/casbin/projects
A preview of the result can be seen here: https://sonarcloud.io/organizations/leonardo-ferreira/projects