casbin / Casbin.NET

An authorization library that supports access control models like ACL, RBAC, ABAC in .NET (C#)
https://casbin.org
Apache License 2.0
1.14k stars 110 forks source link

feat: Add globMatch as a global built-in matcher function #232

Closed dviry closed 2 years ago

dviry commented 2 years ago

Fix: https://github.com/casbin/Casbin.NET/issues/231

Implemented as a global built-in function and added related unit tests.

sagilio commented 2 years ago

LGTM, please fix here errors image

You only need to change the message and add the -s param on commit, thank you!

git commit -s --amend -m "feat: Add globMatch as a global built-in matcher function"
hsluoyz commented 2 years ago

@dviry plz fix:

image

cc @Leonardo-Ferreira

dviry commented 2 years ago

@hsluoyz Not sure how am I supposed to fix that when all tests completed successfully and the error message states:

The format of the analysis property sonar.login= is invalid
hsluoyz commented 2 years ago

@Leonardo-Ferreira @sagilio can you resolve the Sonar error?

sagilio commented 2 years ago

@dviry plz fix:

image

cc @Leonardo-Ferreira

We can skip sonar on PR

casbin-bot commented 2 years ago

@sagilio @xcaptain @huazhikui please review

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.12.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: