Closed AsakusaRinne closed 1 year ago
@sagilio please review
@AsakusaRinne fix:
@AsakusaRinne
:tada: This PR is included in version 2.0.0-preview.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Support batch enforce and add corresponding test. #166
It used async stream to implement
BatchEnforceAsync
exceptNET452
.It added
BatchEnforceParallel
inEnforcer
without a corresponding interface inIEnforcer
. I'm not sure about the design here. What I think is that its only a special implementation so that adding it toIEnforcer
may mean little.As for the extension, I only provide methods which accept generic type inherited from
IRequestValues
. The reason is that if I provide similar API with that ofEnforceExtension.GenericEnforce
, users need to pass severalIEnumerable
, such ase.BatchEnforce(List<T1>, List<T2>, List<T3>)
. Thus, consistency of the parameters is not actually ensured, which I think may not be a good practice. Please give some suggestions about it.I'll PR a benchmark of it if the design is approved finally.