casbin / Casbin.NET

An authorization library that supports access control models like ACL, RBAC, ABAC in .NET (C#)
https://casbin.org
Apache License 2.0
1.13k stars 110 forks source link

Fix CI error #292

Closed hsluoyz closed 1 year ago

hsluoyz commented 1 year ago

https://github.com/casbin/Casbin.NET/actions/runs/3079717027/jobs/4976271164

image

casbin-bot commented 1 year ago

@sagilio @sociometry @AsakusaRinne

hsluoyz commented 1 year ago

@AsakusaRinne after merging your PR: https://github.com/casbin/Casbin.NET/pull/284, caused this issue. Can you fix it?

/cc @sagilio

AsakusaRinne commented 1 year ago

@AsakusaRinne after merging your PR: #284, caused this issue. Can you fix it?

/cc @sagilio

It's not an error caused by the added unit test code of #284. It's in fact because of the new feature of C# 11 (see this doc), and the latest .NET 7.0 RC takes it.

The PR #289 which was merged into preview branch solved this ci error btw, by adding scoped to parameters with in. I think the ci error would be solved after merging preview into master. @sagilio Plz help to have a look.

hsluoyz commented 1 year ago

@sagilio we should release new version soon

sagilio commented 1 year ago

@hsluoyz fixed image

hsluoyz commented 1 year ago

Fixed