casbin / casbin-hub

The hub for Casbin
https://dashboard.casbin.com
Apache License 2.0
88 stars 46 forks source link

Codebase should be integrated with Prettier and Eslint #18

Open aryamanpuri opened 4 years ago

aryamanpuri commented 4 years ago

Additional Information I am working on it .

xprilion commented 4 years ago

Hi @aryamanpuri, please refrain from creating such issues. It is against the spirit of open source if you don't even describe the issue and simply write "I'm working on it".

A good issue should have -

  1. The problem you're facing
  2. Steps to replicate problem (if applicable)
  3. What is expected
  4. Any idea you have about solving the issue
  5. A checklist of points to check this issue's resolution against

Also, if you're willing to work on any issue, put down your proposed solution in a new comment after the issue description. Request repo admin to assign the issue to you based on the merit of your proposed solution.

Hope this helps you in future issues.

aryamanpuri commented 4 years ago

@xprilion Sorry for that

Problem Faced Codebase should be aligned which helps the user and the developers to read the code easily.

To Reproduce It can be seen in the project codebase.

Actual behavior Nothing happens.

Expected behavior Codebase integrated with prettier and eslint will help the code to ensure consistent rules are being followed for indentation, spacing, semicolons, single quotes vs double quotes etc

aryamanpuri commented 4 years ago

@xprilion Are you mentoring this project for GSOC 2020?

xprilion commented 4 years ago

Hey @aryamanpuri, thanks for addressing my suggestions.

No, I'm unfortunately not associated with GSoC anyway this year. I was simply looking through the new organizations this year and found your issue as the first one on this repo and chimed in with a hope to help you create better issues in the future! :slightly_smiling_face: