casbin / casbin-hub

The hub for Casbin
https://dashboard.casbin.com
Apache License 2.0
87 stars 46 forks source link

A better message response to forms #53

Closed thebishaldeb closed 4 years ago

thebishaldeb commented 4 years ago

Updated response message while saving changes using antd message component.

Description

Actual Behaviour

Currently when a button is clicked, we do not really know if the changes are taking place until a response message shows up after the execution.

Expected Behaviour

Now when form will be submitted, a better response will be shown which is taken care of using message.destroy() and message.loading() components. The message keeps on showing until the completion or failure of action.

Screenshot of changes :

message

Checks:

thebishaldeb commented 4 years ago

Have a look at it @hsluoyz Thanks.

hsluoyz commented 4 years ago

Don't let Merge with upstream. show up.

Don't modify code style.

Show a demo.

thebishaldeb commented 4 years ago

Updated. @hsluoyz Please have a look now.

nodece commented 4 years ago

The PR too long, and the new code may fix it. thanks for contribution.