Update the footer - Githubissues

casbin / casbin-hub

The hub for Casbin

https://dashboard.casbin.com

Apache License 2.0

87 stars 46 forks source link

Update the footer #60

Closed Ishaan28malik closed 4 years ago

Ishaan28malik commented 4 years ago

Description: Added red color to the heart SVG

Please ensure Checkmark the following :

[x] - Tested Localy
[x] - Checked in IE11 and Firefox
[x] - Checked in mobile
[x] - Backend work
[x] - Frontend work
[ ] - Bug Fixes
[x] - Enhancements

Wynnfan commented 4 years ago

Your commit does not match the style shown below image.

Ishaan28malik commented 4 years ago

@Wynnfan I suppose u didn't check it by running locally on your system, it does look like this

Maybe you were not able to see the changes because of the conflicts? @Wynnfan

Wynnfan commented 4 years ago

@Wynnfan I suppose u didn't check it by running locally on your system, it does look like this

Maybe you were not able to see the changes because of the conflicts? @Wynnfan

My local style is good and doesn't need any changes, it just seems like dashboard.casbin.org has a problem.

hsluoyz commented 4 years ago

Footer fixed.