search

casbin / casbin-hub

The hub for Casbin
https://dashboard.casbin.com
Apache License 2.0
87 stars 46 forks source link

Update App.js #81

Closed Xiaoyang-Gu closed 4 years ago

Xiaoyang-Gu commented 4 years ago

Fixes : [#10 ]

Description :

fix #10 to avoid some warnings in the console.

Screenshot of changes :

Please ensure Checkmark the following :

hsluoyz commented 4 years ago

@438561537 the PR message needs to be improved.

  1. Write like Fix #XX, your words are not recognized by GitHub.
  2. Don't include unnecessary screenshots. Provide links.
  3. Your checkmarks are not in correct style.

@BetaCat0 can you help him make it right?

BetaCat0 commented 4 years ago

@hsluoyz Yes. @438561537 Once you finish your work, please assign me for code reviewing :)

Xiaoyang-Gu commented 4 years ago

@hsluoyz @BetaCat0 Sorry for these problems caused by wrong operation. Next time i may seriously check the operation and looking for your help.

hsluoyz commented 4 years ago

@438561537 Fix #XX is still not fixed. No brackets.

6ecuk commented 4 years ago

@438561537 Your pull request wasn't merged in master

hsluoyz commented 4 years ago

@6ecuk please reivew.

6ecuk commented 4 years ago

I checked yesterday and warning in the console is gone

Xiaoyang-Gu commented 4 years ago

@6ecuk Thanks, thanks for your your attention.