search

casbin / casbin-hub

The hub for Casbin
https://dashboard.casbin.com
Apache License 2.0
87 stars 46 forks source link

Typo in Readme #92

Closed arteevraina closed 3 years ago

arteevraina commented 4 years ago

While the React's client-side port runs on port 3000 but in the readme, it has been mentioned that it runs on port 3030.

Additional Information: I will make a PR for this.

BetaCat0 commented 4 years ago

Yes, please 👍

arteevraina commented 4 years ago

@BetaCat0 Sure thing.

hsluoyz commented 4 years ago

@arteevraina it runs on 3030:

https://github.com/casbin/casbin-dashboard/blob/7851225732e602626eab7c95a57eea8967542539/web/package.json#L18-L23

arteevraina commented 4 years ago

@hsluoyz But the logs say something like this :

Compiled successfully!

You can now view web in the browser.

  Local:            http://localhost:3000/
  On Your Network:  http://192.168.1.8:3000/

Note that the development build is not optimized.
To create a production build, use npm run build.

Correct me if I am wrong.

hsluoyz commented 4 years ago

It's because of OS.

arteevraina commented 4 years ago

It's because of OS.

ok, thanks :)