search

casbin / casbin-mesh

A scalable authorization layer built on Casbin (The experimental project is currently unstable)
https://mesh.casbin.org
Apache License 2.0
25 stars 13 forks source link

feat(raft): introduce read index #57

Closed noneback closed 2 months ago

noneback commented 2 years ago

Signed-off-by: noneback chenlan_of_learn@126.com

casbin-bot commented 2 years ago

@WenyXu @nodece please review

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

noneback commented 2 years ago

Draft. I only change the enforce-related code to see if it fits.

hsluoyz commented 2 years ago

@noneback don't make WIP PR. First work in your local branch and then create the final PR

nodece commented 2 years ago

I need to spend some time for review this PR.

noneback commented 2 years ago

nodece

Thx for your patience！ You can review it at your convenience.

WenyXu commented 2 years ago

Well done, But I consider we still need to add tests for this PR. Before adding tests, we need to decouple the main function's parsing flags(the relevant issue #58 ), which makes integration testing more manageable. I will handle this issue later this week. If you are willing, you can make a decoupling of the parsing flags PR, then add tests for this PR.

nodece commented 2 years ago

Thanks for your contribution, most of the work is great, I left my comment.

noneback commented 2 years ago

Thx. I will fix them all in my spare time.

hsluoyz commented 2 years ago

@noneback can you continue pushing this PR? Also resolve the conflict:

image

noneback commented 2 years ago

Sure. I will fix conflict and try to add some test

hsluoyz commented 2 years ago

/cc @nodece @WenyXu