Thoughts on using database/sql instead of go-pg?

[fgblomqvist]

Since this adapter is very light-weight, have you guys considered switching out go-pg to the built-in database/sql package? It would make this a very attractive pure SQL adapter with very few/small dependencies.

[pckhoi]

Can you tell us the reason why to switch to database/sql? I didn't stumble on and use go-pg by accident but for its ease of use and practicality.

[hsluoyz]

@fgblomqvist why not use https://github.com/casbin/gorm-adapter or https://github.com/casbin/xorm-adapter ?

[fgblomqvist]

@pckhoi The reason would be because all that is being done are simple "select where" queries as well as basic insert/delete ones. You're basically using the table as a CSV, just storing a bunch of strings. Swapping to database/sql would probably barely result in any more code needing to be written. But hey, it's just a thought. I guess the question is, why do you feel like an ORM is needed?

@hsluoyz Because those also use ORMs (and have several dependencies)?

This is a good example: https://github.com/cychiuae/casbin-pg-adapter

However, it doesn't support filtered policy-loading. But yeah I figured I'd ask here since I was curious what the motivation was for using an ORM, since this is the "official" pg adapter.

[pckhoi]

The ORM choice isn't made specifically to write this adapter. Instead this adapter was made for those who are already using go-pg. Does that answer your question?

[hsluoyz]

@fgblomqvist we have a lot of adapters that support PostgreSQL: https://casbin.org/docs/en/adapters What about these ones?

• https://github.com/Blank-Xu/sql-adapter
• https://github.com/going/casbin-postgres-adapter
• https://github.com/going/casbin-postgres-adapter

(the tag "Archived" doesn't matter as we can take it back any time:))

[fgblomqvist]

@pckhoi Yes it does. However, might want to change how this adapter is listed on the adapters page then. It's currently (in that case) incorrectly listed as a "Filtered PostgreSQL adapter" and type "SQL" rather than "go-pg Adapter" type "ORM".

@hsluoyz The first uses sqlx and the latter 2 (which are the same) look unfinished. Either way, like I said, there is a good one already available that uses only database/sql, but it doesn't supported the filtering yet. Probably fairly trivial to add that to it though so I think I'll go that route.

[hsluoyz]

@fgblomqvist OK. Can you also send an issue to: https://github.com/cychiuae/casbin-pg-adapter ? So we can know whether the owner is still active and will make changes for you or be able to review/accept our PR.

[fgblomqvist]

https://github.com/cychiuae/casbin-pg-adapter/issues/3

[hsluoyz]

Closed here.