Closed 0xethsign closed 3 years ago
Merging #249 (6f92b17) into master (5ee0e10) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 79.99% 79.99%
=======================================
Files 22 22
Lines 3429 3429
=======================================
Hits 2743 2743
Misses 686 686
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5ee0e10...6f92b17. Read the comment docs.
@hackerchai
lgtm
The sole purpose of this PR is to delete the previous benchmark. The reason is - On every pull request, the github actions for criterion compares the benchmark of the master branch and the pull request commits. https://github.com/boa-dev/criterion-compare-action/tree/move_to_actions runs cargo commands that don't run on the rust nightly toolchains. On the other hand, the existing benchmark library runs on the nightly toolchain. Thus the CI fails when comparing the both - https://github.com/casbin/casbin-rs/pull/242/checks?check_run_id=2285035133.
It is required to delete the existing benchmark dependency before migrating to criterion.rs - #242.
Signed-off-by: smrpn samarpan_d@pp.iitr.ac.in