casbin / casbin-rs

An authorization library that supports access control models like ACL, RBAC, ABAC in Rust.
https://casbin.org
Apache License 2.0
851 stars 72 forks source link

feat: add comment for benchmark result #256

Closed 0xethsign closed 3 years ago

0xethsign commented 3 years ago

There is a issue with criterion-benchmark-action. This does not allow comments from PRs from forked repositories. ref - https://github.community/t5/GitHub-Actions/quot-Resource-not-accessible-by-integration-quot-for-adding-a/td-p/33925 This will allow comments from PRs inside the repository only.

Signed-off-by: smrpn samarpan_d@pp.iitr.ac.in

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@542e22e). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage          ?   79.99%           
=========================================
  Files             ?       22           
  Lines             ?     3429           
  Branches          ?        0           
=========================================
  Hits              ?     2743           
  Misses            ?      686           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 542e22e...5293102. Read the comment docs.

hsluoyz commented 3 years ago

@hackerchai

hackerchai commented 3 years ago

@smrpn you need to modify github_token to bench_github_token

hackerchai commented 3 years ago

@smrpn please fix this error

hsluoyz commented 3 years ago

@smrpn

image