casbin / casbin-rs

An authorization library that supports access control models like ACL, RBAC, ABAC in Rust.
https://casbin.org
Apache License 2.0
863 stars 74 forks source link

feat: Initial migration from rust 2018 to rust 2021 #290

Closed SiddheshKanawade closed 2 years ago

SiddheshKanawade commented 2 years ago

Steps followed to migrate from rust 2018 to 2021:

  1. cargo update
  2. cargo fix –-edition
  3. updated the cargo.toml --edition
  4. ran cargo build and cargo test to check whether changes are implemented and code is running. The warnings were resolved after the update in main repository which included the change of syntax of def_package! compatible with latest rhai edition
  5. Updated the Cargo.toml file dependencies to their latest version
  6. cargo +nightly udeps to check the unused dependencies, found none
  7. cargo outdated to check outdated dependencies, found some, updated via cargo update
  8. cargo build and cargo test to verify the changes are implemented successfully

Following is the output when ran cargo outdated Screen Shot 2022-03-03 at 7 44 40 PM

Following is the output when ran cargo +nightly udeps Screen Shot 2022-03-03 at 7 46 01 PM

casbin-bot commented 2 years ago

@smrpn @hackerchai @PsiACE @GopherJ please review

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: SiddheshKanawade
:x: macbook air


macbook air seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

hsluoyz commented 2 years ago

@SiddheshKanawade plz fix:

image

codecov[bot] commented 2 years ago

Codecov Report

Merging #290 (908cab6) into master (9320add) will decrease coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head 908cab6 differs from pull request most recent head 972f773. Consider uploading reports for the commit 972f773 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   81.03%   81.03%   -0.01%     
==========================================
  Files          23       23              
  Lines        3338     3337       -1     
==========================================
- Hits         2705     2704       -1     
  Misses        633      633              
Impacted Files Coverage Δ
src/rbac/default_role_manager.rs 98.12% <0.00%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9320add...972f773. Read the comment docs.

SiddheshKanawade commented 2 years ago

@PsiACE I have already signed the CLA, but it isn't showed in the status Screen Shot 2022-03-03 at 8 50 51 PM

PsiACE commented 2 years ago

@PsiACE I have already signed the CLA, but it isn't showed in the status Screen Shot 2022-03-03 at 8 50 51 PM

ref https://github.com/casbin/casbin-rs/pull/290#issuecomment-1058088835

macbook air seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

SiddheshKanawade commented 2 years ago

@PsiACE I am getting error while adding email address and I read the official documentation and it says I can't update the email address for previous commits, so I will be closing this PR and will make a new PR, will this work?