Closed SiddheshKanawade closed 2 years ago
@smrpn @hackerchai @PsiACE @GopherJ please review
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: SiddheshKanawade
:x: macbook air
@SiddheshKanawade plz fix:
Merging #290 (908cab6) into master (9320add) will decrease coverage by
0.00%
. The diff coverage isn/a
.:exclamation: Current head 908cab6 differs from pull request most recent head 972f773. Consider uploading reports for the commit 972f773 to get more accurate results
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 81.03% 81.03% -0.01%
==========================================
Files 23 23
Lines 3338 3337 -1
==========================================
- Hits 2705 2704 -1
Misses 633 633
Impacted Files | Coverage Δ | |
---|---|---|
src/rbac/default_role_manager.rs | 98.12% <0.00%> (-0.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9320add...972f773. Read the comment docs.
@PsiACE I have already signed the CLA, but it isn't showed in the status
@PsiACE I have already signed the CLA, but it isn't showed in the status
ref https://github.com/casbin/casbin-rs/pull/290#issuecomment-1058088835
macbook air seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
@PsiACE I am getting error while adding email address and I read the official documentation and it says I can't update the email address for previous commits, so I will be closing this PR and will make a new PR, will this work?
Steps followed to migrate from rust 2018 to 2021:
cargo update
cargo fix –-edition
cargo.toml
--editioncargo build
andcargo test
to check whether changes are implemented and code is running. The warnings were resolved after the update in main repository which included the change of syntax ofdef_package!
compatible with latestrhai
editionCargo.toml
file dependencies to their latest versioncargo +nightly udeps
to check the unused dependencies, found nonecargo outdated
to check outdated dependencies, found some, updated viacargo update
cargo build
andcargo test
to verify the changes are implemented successfullyFollowing is the output when ran![Screen Shot 2022-03-03 at 7 44 40 PM](https://user-images.githubusercontent.com/85673539/156582414-ebe2e66d-90a0-4b14-9505-aaac8335731c.png)
cargo outdated
Following is the output when ran![Screen Shot 2022-03-03 at 7 46 01 PM](https://user-images.githubusercontent.com/85673539/156582513-acb2faa6-bc14-4adf-a912-93d42e3960d0.png)
cargo +nightly udeps