Closed SiddheshKanawade closed 2 years ago
@smrpn @hackerchai @PsiACE @GopherJ please review
@PsiACE I have created a new PR since in last one I was not able to sign CLA, now all the initial checks are done, kindly review the PR.
Merging #291 (3d26998) into master (9320add) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 81.03% 81.03% -0.01%
==========================================
Files 23 23
Lines 3338 3337 -1
==========================================
- Hits 2705 2704 -1
Misses 633 633
Impacted Files | Coverage Δ | |
---|---|---|
src/rbac/default_role_manager.rs | 98.12% <0.00%> (-0.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9320add...3d26998. Read the comment docs.
@PsiACE please let me know what else I need to do to complete the migration from Rust 2018 to Rust 2021
@PsiACE please let me know what else I need to do to complete the migration from Rust 2018 to Rust 2021
For casbin-rs, that's enough. Other projects may need to fix a lot of clippy lints
@PsiACE please let me know what else I need to do to complete the migration from Rust 2018 to Rust 2021
For casbin-rs, that's enough. Other projects may need to fix a lot of clippy lints
@PsiACE I was trying to understand more about the rust project this year for GSOC '22, it had Embrace Rust 2021 edition
as one of its key point, so what else I have to do in completing the first task in the list?
so what else I have to do in completing the first task in the list?
Since the expectation for the first task is that the candidate will be familiar with Rust and Casbin, perhaps you could consider trying to maintain our example?
so what else I have to do in completing the first task in the list?
Since the expectation for the first task is that the candidate will be familiar with Rust and Casbin, perhaps you could consider trying to maintain our example?
Sure, I will try to contribute to it, can you please guide me where should I start?
Sure, I will try to contribute to it, can you please guide me where should I start?
First, I suggest you check their availability. Then, help them to upgrade their dependencies correctly. In addition to ensuring that they pass CI, I recommend that you build some simple integration tests for them.
Sure, I will try to contribute to it, can you please guide me where should I start?
First, I suggest you check their availability. Then, help them to upgrade their dependencies correctly. In addition to ensuring that they pass CI, I recommend that you build some simple integration tests for them.
Thank you for the help, I will surely try to integrate these suggestions in my code
Steps followed to migrate from rust 2018 to 2021:
cargo update
cargo fix –-edition
cargo.toml
--editioncargo build
andcargo test
to check whether changes are implemented and code is running. The warnings were resolved after the update in the main repository which included the change of syntax of def_package! compatible with latestrhai
editionCargo.toml
file dependencies to their latest versioncargo +nightly udeps
to check the unused dependencies, found nonecargo outdated
to check outdated dependencies, found some, updated viacargo update
cargo build
andcargo test
to verify the changes are implemented successfully