Closed kbalt closed 2 years ago
@smrpn @hackerchai @PsiACE @GopherJ please review
@kbalt fix:
@PsiACE
Merging #293 (c111b47) into master (41db260) will increase coverage by
0.49%
. The diff coverage is93.72%
.
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 81.02% 81.52% +0.49%
==========================================
Files 23 23
Lines 3342 3480 +138
==========================================
+ Hits 2708 2837 +129
- Misses 634 643 +9
Impacted Files | Coverage Δ | |
---|---|---|
src/adapter/file_adapter.rs | 61.45% <0.00%> (+0.63%) |
:arrow_up: |
src/rbac/default_role_manager.rs | 96.29% <95.23%> (-1.83%) |
:arrow_down: |
src/rbac_api.rs | 89.37% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 41db260...c111b47. Read the comment docs.
Great, thank you very much for your contribution! I will check it tomorrow, can you let ci pass first?
@PsiACE Any updates on this?
@PsiACE Any updates on this?
I apologise for some changes in my role that caused me to forget to give feedback earlier.
The PR looks great and I will be approving it. But before we merge, I'd like @hackerchai to help review it again.
LGTM
This relation model is built after the Go implementation, but uses edges inside the graph to model relations instead of having each role store pointers in maps.
Edges with the
EdgeVariant::Link
are relations which in Go are modeled by theroles
andusers
map. Edges with theEdgeVariant::Match
are relations which is Go are modeled by thematched
andmatchedBy
map.This change brings significant speedups in benchmarks when compared against the master branch.