Closed kbalt closed 1 year ago
@kbalt plz fix the CI errors
Merging #307 (f9dd3f6) into master (e161068) will decrease coverage by
14.12%
. The diff coverage is78.94%
.
@@ Coverage Diff @@
## master #307 +/- ##
===========================================
- Coverage 81.46% 67.34% -14.12%
===========================================
Files 23 24 +1
Lines 3463 1779 -1684
===========================================
- Hits 2821 1198 -1623
+ Misses 642 581 -61
Impacted Files | Coverage Δ | |
---|---|---|
src/cached_enforcer.rs | 0.00% <0.00%> (-4.17%) |
:arrow_down: |
src/convert.rs | 57.14% <ø> (+11.98%) |
:arrow_up: |
src/enforcer.rs | 70.53% <ø> (-16.72%) |
:arrow_down: |
src/adapter/file_adapter.rs | 62.50% <100.00%> (+1.04%) |
:arrow_up: |
src/cache/default_cache.rs | 100.00% <100.00%> (+2.94%) |
:arrow_up: |
src/macros.rs | 50.00% <100.00%> (ø) |
|
src/rbac/default_role_manager.rs | 95.21% <100.00%> (-2.22%) |
:arrow_down: |
... and 10 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@kbalt plz fix:
Code coverage is complaining about a huge coverage regression in src/enforcer.rs
when I just added one single line in there. The rest should be resolved now.
Replace the
lru
library withmini-moka
for caching. This allows the API to take&self
instead of&mut self
for most operations.This also allows to only take a read lock when executing
g
functions.