Closed mooleetzi closed 9 months ago
Merging #308 (b85da0e) into master (2bd7ef5) will decrease coverage by
0.32%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 67.34% 67.02% -0.32%
==========================================
Files 24 24
Lines 1779 1777 -2
==========================================
- Hits 1198 1191 -7
- Misses 581 586 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/management_api.rs | 67.42% <ø> (-2.28%) |
:arrow_down: |
src/model/default_model.rs | 92.81% <ø> (-0.66%) |
:arrow_down: |
src/rbac_api.rs | 83.08% <ø> (ø) |
|
src/enforcer.rs | 70.24% <100.00%> (-0.29%) |
:arrow_down: |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Haven’t tried it out but any reason this is closed? Would really love to have this bug fixed.
@prabirshrestha this PR has CI errors and it seems that the original author has closed it. Would you like to create a new PR?
I'm not comfortable signing CLA without discussing with the legal team.
Looking at the build errors seems like it is only related to clippy issues and is an easy fix. Wondering if @mooleetzi or owners can fix it. More than happy to test it out.
@mooleetzi @prabirshrestha we should add the FilterAdapter
interface and follow the design of Go Casbin.
Fix: https://github.com/casbin/casbin-rs/issues/304
in casbin-rs, there is no
FilterAdapter
, all adapters implement traitadapter
which has methodload_filtered_policy
, thus we cannot determine if we can callload_policy
inEnforcer:new
by object type, all we can do is not callload_policy
orload_filtered_policy
until use.