search

casbin / casbin-rs

An authorization library that supports access control models like ACL, RBAC, ABAC in Rust.
https://casbin.org
Apache License 2.0
863 stars 74 forks source link

2.4.0 was a breaking change #340

Closed BatmanAoD closed 2 months ago

BatmanAoD commented 2 months ago

The add_function signature changed, which breaks builds relying on this crate.

MuZhou233 commented 2 months ago

The old signature is inconsist with document and blocks implemeting of key_get function. See #338 I don't have a way to not change the API. Do you have some idea?

BatmanAoD commented 2 months ago

@MuZhou233 I understand that the new API is necessary for certain features, but to avoid breaking people's builds unnecessarily, I think it would have been preferable to bump the version up to 3.0.

hsluoyz commented 2 months ago

@BatmanAoD this is a small feature and not many people are using it. So we will not trigger a major release for it.