search

casbin / casbin.js

An authorization library that supports access control models like ACL, RBAC, ABAC in Frontend Javascript
https://casbin.org/docs/en/frontend
Apache License 2.0
165 stars 37 forks source link

feat: add full support for sync api. #148

Closed Zxilly closed 3 years ago

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1109906351

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/model.ts 3 4 75.0%
src/coreEnforcer.ts 7 10 70.0%
src/rbac/defaultSyncedRoleManager.ts 2 11 18.18%
src/rbac/internalRoleManager.ts 108 122 88.52%
src/util/builtinOperators.ts 9 26 34.62%
src/syncedEnforcer.ts 5 75 6.67%
<!-- Total: 152 266 57.14% -->
Files with Coverage Reduction New Missed Lines %
src/internalEnforcer.ts 1 57.87%
src/enforcer.ts 4 91.86%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 1107690622: -3.4%
Covered Lines: 1211
Relevant Lines: 1589
💛 - Coveralls
hsluoyz commented 3 years ago

@Zxilly don't append "Revert: xxx" commit, just override the git history:

image

Zxilly commented 3 years ago

It's impossilbe to make async function works like sync.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 1109906351

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/model.ts 3 4 75.0%
src/coreEnforcer.ts 7 10 70.0%
src/rbac/defaultSyncedRoleManager.ts 2 11 18.18%
src/rbac/internalRoleManager.ts 108 122 88.52%
src/util/builtinOperators.ts 9 26 34.62%
src/syncedEnforcer.ts 5 75 6.67%
<!-- Total: 152 266 57.14% -->
Files with Coverage Reduction New Missed Lines %
src/internalEnforcer.ts 1 57.87%
src/enforcer.ts 4 91.86%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 1107690622: -3.4%
Covered Lines: 1211
Relevant Lines: 1589
💛 - Coveralls