feat: support customized table

casbin / gorm-adapter

GORM adapter for Casbin, see extended version of GORM Adapter Ex at: https://github.com/casbin/gorm-adapter-ex

https://github.com/casbin/casbin

Apache License 2.0

679 stars 206 forks source link

feat: support customized table #168

Closed JalinWang closed 2 years ago

JalinWang commented 2 years ago

fix #167

casbin-bot commented 2 years ago

@tangyang9464 @closetool @sagilio please review

hsluoyz commented 2 years ago

@basimsahaf @tangyang9464 plz review

hsluoyz commented 2 years ago

@JalinWang

hsluoyz commented 2 years ago

@basimsahaf plz review

hsluoyz commented 2 years ago

@JalinWang fix conflicts:

JalinWang commented 2 years ago

@JalinWang fix conflicts:

@hsluoyz Done

hsluoyz commented 2 years ago

@JalinWang fix:

tangyang9464 commented 2 years ago

@JalinWang Does this PR support custom v0-v5？

JalinWang commented 2 years ago

@JalinWang Does this PR support custom v0-v5？

Currently, no. I'll work on it in days.

JalinWang commented 2 years ago

@JalinWang fix:

@hsluoyz SORRRRY but now it's okay. Annoying conflict resolving 😣.

hsluoyz commented 2 years ago

@JalinWang this PR makes code too complicated just to implement a not-so-important extra functionality, gorm-adapter is a benchmarking example and it should be kept simple. I suggest we putting this code into another adapter repo