search

casbin / jcasbin

An authorization library that supports access control models like ACL, RBAC, ABAC in Java
https://casbin.org
Apache License 2.0
2.4k stars 464 forks source link

Rename all "jcasbin"s to "casbin" except this GitHub repo name #143

Closed hsluoyz closed 3 years ago

hsluoyz commented 3 years ago

We will rename to "casbin" for everywhere including the Maven package manager, except this GitHub repo name to differentiate with Go's Casbin.

shy1st commented 3 years ago

The following project does not use "casbin" for groupId config.

  1. jcasbin-springboot-plugin
  2. jfinal-authz
  3. vertx-casbin
  4. jcasbin-nutz-plugin
  5. jfinal-demo
Zxilly commented 3 years ago

Reserve current version jCasbin, and make further update in the Casbin may be a good idea.

hsluoyz commented 3 years ago

@Zxilly what do you mean?

Zxilly commented 3 years ago

@hsluoyz Keep this version of jCasbin for compatibility with other module, but no longer develop on this. But create a new repository named casbin ,and make further contribution on that.

hsluoyz commented 3 years ago

@Zxilly the github repo doesn't matter. The commits remain anyway. I'm talking abou the Maven central. We will freeze the new versions under jcasbin and release new versions with casbin.

hsluoyz commented 3 years ago

@shy1st I don't know how Maven Central treats such a situation. Is Casbin a new package than jCasbin? If yes, then we are releasing new package.

shy1st commented 3 years ago

In maven central, the groupid we set is always " org.casbin" , does not exist "org.jcasbin". please see https://mvnrepository.com/search?q=casbin.

hsluoyz commented 3 years ago

@shy1st In the Java side (code, etc.), there should be only "casbin", there's no "jcasbin". "jcasbin" is only used in this repo name and also in Casbin official website.

shy1st commented 3 years ago

@hsluoyz I think this is mainly reflected in the setting of groupid in POM files. In some projects, the groupid is set as org.jcasbin(eg:vertx-casbin), which is incorrect. This will cause an exception when published to the central repository(In fact, vertx-casbin has not published to the central repository）.

hsluoyz commented 3 years ago

@shy1st good, then fix those wrong group IDs.

ebreak commented 3 years ago

trying to work on this

hsluoyz commented 3 years ago

@shy1st , let me introduce @Kininaru , @Kininaru is our technical writer for Casbin docs & website. He also has some interest in languages like C++, Java, etc., so he will hang around our repos. Hope @Kininaru can be a help for you!

shy1st commented 3 years ago

@Kininaru Welcome!

shy1st commented 3 years ago

@Kininaru @hsluoyz I think all the project in jcasbin organization has renamed. Now we can close this issue.

hsluoyz commented 3 years ago

Great!