search

casbin / jcasbin

An authorization library that supports access control models like ACL, RBAC, ABAC in Java
https://casbin.org
Apache License 2.0
2.38k stars 461 forks source link

CSV values escaped using \ #356

Closed pzet123 closed 1 year ago

pzet123 commented 1 year ago

Escaping CSV values was discussed in #243 however the resolution in the end was to use \ for escaping commas in CSV files.

This causes an issue when trying to share policies between different versions of Casbin (e.g. Node-Casbin and jCasbin) which use double quotation marks to format values. This is the preferred technique described in RFC4180.

Is there any reason not to switch to the method of escaping CSV values described in RFC4180?

casbin-bot commented 1 year ago

@tangyang9464 @imp2002

hsluoyz commented 1 year ago

@pzet123 hi, can you make a PR?

hsluoyz commented 1 year ago

@pzet123 any update?

pzet123 commented 1 year ago

Submitted PR