casbin / jcasbin

An authorization library that supports access control models like ACL, RBAC, ABAC in Java
https://casbin.org
Apache License 2.0
2.4k stars 464 forks source link

feat: support rbac-with-conditions for jcasbin #392

Closed LMay001 closed 7 months ago

LMay001 commented 7 months ago

feat: support rbac-with-conditions for jcasbin

Fix: https://github.com/casbin/jcasbin/issues/384

casbin-bot commented 7 months ago

@tangyang9464 @imp2002 please review

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 62.53968% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 67.80%. Comparing base (c7d1c21) to head (bfce89a).

Files Patch % Lines
...rg/casbin/jcasbin/rbac/ConditionalRoleManager.java 62.92% 17 Missing and 16 partials :warning:
.../main/java/org/casbin/jcasbin/model/Assertion.java 38.46% 27 Missing and 5 partials :warning:
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 75.80% 12 Missing and 3 partials :warning:
...java/org/casbin/jcasbin/util/BuiltInFunctions.java 77.35% 7 Missing and 5 partials :warning:
.../org/casbin/jcasbin/rbac/LinkConditionFuncKey.java 37.50% 6 Missing and 4 partials :warning:
src/main/java/org/casbin/jcasbin/rbac/Role.java 66.66% 9 Missing :warning:
src/main/java/org/casbin/jcasbin/model/Policy.java 56.25% 3 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #392 +/- ## ========================================== - Coverage 68.92% 67.80% -1.12% ========================================== Files 53 55 +2 Lines 2420 2721 +301 Branches 427 505 +78 ========================================== + Hits 1668 1845 +177 - Misses 638 725 +87 - Partials 114 151 +37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

:tada: This PR is included in version 1.55.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: