casbin / jcasbin

An authorization library that supports access control models like ACL, RBAC, ABAC in Java
https://casbin.org
Apache License 2.0
2.38k stars 461 forks source link

Is it good that the code throws java.lang.Error in Java ? #5

Closed chinleo closed 5 years ago

hsluoyz commented 5 years ago

It's not a good practice. We will fix it these days. You are also welcome to propose PR for us :)

hsluoyz commented 5 years ago

Hi @fangzhengjin , can you fix this one?

fangzhengjin commented 5 years ago

Hi @fangzhengjin , can you fix this one?

I will try to fix it, but it may affect some test cases, so the test case must be processed with try catch.

hsluoyz commented 5 years ago

Hi @chinleo , this issue has been fixed in: https://github.com/casbin/jcasbin/pull/31