feat: ensure eft and priority are respected in p2, r2, etc

casbin / node-casbin

An authorization library that supports access control models like ACL, RBAC, ABAC in Node.js and Browser

https://casbin.org

Apache License 2.0

2.61k stars 218 forks source link

feat: ensure eft and priority are respected in p2, r2, etc #475

Closed sophiebella28 closed 6 months ago

sophiebella28 commented 6 months ago

In a few places, it was still hardcoded to only look for the priority and effect of p, instead of using the ptype variable. Fixed so that it now has the same behaviour regardless of the order

fix #474

casbin-bot commented 6 months ago

@nodece @Shivansh-yadav13 please review

CLAassistant commented 6 months ago

All committers have signed the CLA.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 5.30.0 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: