search

casbin / xorm-adapter

Xorm adapter for Casbin
https://github.com/casbin/casbin
Apache License 2.0
384 stars 58 forks source link

add RemovePolicies and AddPolicies #32

Closed linxing closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-3.9%) to 54.934% when pulling 0769202b9acd0e8d8253a3fd5554ab97569a54c0 on linxing:feat-implement-batch-adapter into 0ca20dc2bb09df054049df3155096f13264373d4 on casbin:master.

hsluoyz commented 4 years ago

@nodece @GopherJ @00LT00 please review.

00LT00 commented 4 years ago

LGTM

hsluoyz commented 4 years ago

@linxing please add tests to mitigate the Coverage drop.

linxing commented 4 years ago

@hsluoyz @00LT00 I was confuse about the CI test resuts.

hsluoyz commented 4 years ago

@linxing I have restarted the CI: https://travis-ci.org/github/casbin/xorm-adapter

linxing commented 4 years ago

@hsluoyz is the test case incorrect ?

hsluoyz commented 4 years ago

@00LT00 please dig into this issue.

/cc @nodece @GopherJ @dovics

00LT00 commented 4 years ago

@hsluoyz it is correct on my path... image

linxing commented 4 years ago

@hsluoyz it is correct on my path... image

thats weird

00LT00 commented 4 years ago

@linxing When I only tested the mysql adapter, travis-ci passed... I think you could sort the policy on here to pass ci

linxing commented 4 years ago

@linxing When I only tested the mysql adapter, travis-ci passed... I think you could sort the policy on here to pass ci

its test passed with postgres(12.4) and mysql(5.7) on my computer.

hsluoyz commented 4 years ago

Please fix CI, or prove it's wrong.

nodece commented 4 years ago

@linxing please merge master branch, I update CI config.

linxing commented 4 years ago

@linxing please merge master branch, I update CI config.

sorry. I dont have authority to merge the branch

nodece commented 4 years ago

@linxing I mean is merge casbin/master branch to linxing:feat-implement-batch-adapter.

linxing commented 4 years ago

I mean is merge casbin/master branch to linxing:feat-implement-batch-adapter.

got it

linxing commented 4 years ago

@nodece done. but still not pass the ci.

linxing commented 4 years ago

https://github.com/casbin/xorm-adapter/pull/31 this guy got the same errors

nodece commented 4 years ago

thanks for your contributtion, I will fix the CI later.