cascadia-technology / ModernBrowser

10 stars 0 forks source link

Rebuild with latest chromium version #12

Open chachew opened 1 year ago

chachew commented 1 year ago

I was trying to updated this package with the latest version of chromium but ive run into some issues.

Updating the NuGet packages to anything above this version(75.1.14) results in an error in the RegisterJsObject BindingOptions. The CamelCaseJavascriptNames option is no longer valid. If i remove that option from the bindings i will get a successful build but then the plugin no longer functions. The browser no longer loads in the Milestone MIPPlugin. Its just a blank page with nothing loaded and no visible page.

If i downgrade to 75.1.14 again and change nothing, then the plugin works fine. Any ideas on how to fix this? Is this repo no longer maintained?

joshooaj commented 1 year ago

Hi @chachew, I wanted to update to the latest cefsharp version a long time ago but there were breaking changes that made it easier said than done as you discovered.

If I had time/motivation, I would refactor this plugin to completely remove the javascript integration bridging JS and the MIP environment in Smart Client. This Smart Client Scripting (SCS) feature has been a part of the built-in Smart Client browser view item ever since I can remember, and I had wanted to offer something similar in this plugin. But it's something that is so rarely used that it's not worth the trouble to get working again. It's also a big security risk. If a user is able to navigate the browser to a malicious web page, javascript on the page could access the VMS under the security context of the already logged-in Smart Client user.

Some months ago I spent a few minutes doing what was probably the same thing you did to get this to compile and I had the same experience. The browser view item was blank white and the reason wasn't immediately obvious to me why.

I don't foresee spending free time on this project any time soon - you're welcome to investigate if you have the time/interest, otherwise you might try the "Web view" view item from the Axis Optimizer plugin. It looks to be using CefSharp 105.3.330.0 released ~9 months ago.

image