search

cascadium / wsl-windows-toolbar-launcher

Adds linux GUI application menu to a windows toolbar
MIT License
1.21k stars 50 forks source link

Deadlock when using Imagemagick trying to convert some svg icons #23

Closed sursma closed 3 years ago

sursma commented 4 years ago

sursm@LAPTOP-H4P3RT95:~$ wsl-windows-toolbar 2020-10-30 19:05:10,145[WARNING]: Could not find cairosvg - will not be able to convert svg 2020-10-30 19:05:10,361[INFO]: distribution = Ubuntu-20.04 2020-10-30 19:05:10,362[INFO]: user = sursm 2020-10-30 19:05:10,362[INFO]: confirm_yes = False 2020-10-30 19:05:10,362[INFO]: menu_file = /etc/xdg/menus/gnome-applications.menu 2020-10-30 19:05:10,363[INFO]: wsl_executable = C:\Windows\System32\wsl.exe 2020-10-30 19:05:10,363[INFO]: target_name = WSL 2020-10-30 19:05:10,363[INFO]: preferred_theme = Adwaita 2020-10-30 19:05:10,364[INFO]: alternative_theme = ('Papirus', 'Humanity', 'elementary-xfce') 2020-10-30 19:05:10,364[INFO]: jinja_template_batch = None 2020-10-30 19:05:10,364[INFO]: jinja_template_shell = None 2020-10-30 19:05:10,365[INFO]: rc_file = /home/sursm/.bashrc 2020-10-30 19:05:10,365[INFO]: has_imagemagick = True 2020-10-30 19:05:10,365[INFO]: has_cairosvg = False 2020-10-30 19:05:10,366[INFO]: launch_directory = /home/sursm 2020-10-30 19:05:10,465[INFO]: install_directory = /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/menus/WSL 2020-10-30 19:05:10,466[INFO]: metadata_directory = /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL2020-10-30 19:05:10,466[INFO]: For full list of options available, call script again with --help 2020-10-30 19:05:10,467[INFO]: This script will write to the above locations if it can, but giving final chance to chicken out. Press to continue or ctrl+c to abort. 2020-10-30 19:05:14,626[INFO]: Creating menu item for: Accessories/About Xfce 2020-10-30 19:05:16,747[INFO]: Creating menu item for: Accessories/Application Finder 2020-10-30 19:05:17,425[INFO]: Creating menu item for: Accessories/Byobu Terminal 2020-10-30 19:05:18,641[INFO]: Creating menu item for: Accessories/DB Browser for SQLite 2020-10-30 19:05:19,435[INFO]: Creating menu item for: Accessories/File Manager 2020-10-30 19:05:20,351[INFO]: Creating menu item for: Accessories/Run Program... 2020-10-30 19:05:21,357[INFO]: Creating menu item for: Accessories/TeXInfo 2020-10-30 19:05:22,490[INFO]: Creating menu item for: Accessories/Terminal Emulator 2020-10-30 19:05:23,322[INFO]: Creating menu item for: Accessories/Vim 2020-10-30 19:05:24,537[INFO]: Creating menu item for: Accessories/Visual Studio Code 2020-10-30 19:05:25,486[INFO]: Creating menu item for: Graphics/ImageMagick (color depth=q16) 2020-10-30 19:05:26,160[INFO]: Creating menu item for: Internet/FileZilla 2020-10-30 19:05:27,191[INFO]: Creating menu item for: Internet/Mail Reader 2020-10-30 19:05:28,083[INFO]: Creating menu item for: Internet/Web Browser 2020-10-30 19:05:28,848[INFO]: Creating menu item for: Programming/Android Studio

more 3/4 hours nothing happens

I ran by enabling debug logs here is what

.config\wsl-windows-toolbar-launcher\menus\WSL\Internet\FileZilla.lnk");$s.TargetPath = "wscript";$s.Arguments = ""C:\Users\sursm\.config\wsl-windows-toolbar-launcher\metadata\WSL\silent-launcher.vbs" "C:\Users\sursm\.config\wsl-windows-toolbar-launcher\metadata\WSL\Internet\FileZilla.bat"";$s.Description = "Download and upload files via FTP, FTPS and SFTP";$s.WorkingDirectory = "%USERPROFILE%";$s.IconLocation = "C:\Users\sursm.config\wsl-windows-toolbar-launcher\metadata\WSL\Internet\FileZilla.ico";$s.Save()' 2020-10-30 19:08:48,241[DEBUG]: Created C:\Users\sursm.config\wsl-windows-toolbar-launcher\menus\WSL\Internet\FileZilla.lnk 2020-10-30 19:08:48,241[INFO]: Creating menu item for: Internet/Mail Reader 2020-10-30 19:08:48,257[DEBUG]: Will create shortcut file: /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/menus/WSL/Internet/Mail Reader.lnk 2020-10-30 19:08:48,257[DEBUG]: Creating icon files for: emblem-mail, /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL/Internet/Mail Reader [Adwaita] 2020-10-30 19:08:48,302[DEBUG]: STREAM b'IHDR' 16 13 2020-10-30 19:08:48,303[DEBUG]: STREAM b'IDAT' 41 1886 2020-10-30 19:08:48,319[DEBUG]: Successfully created /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL/Internet/Mail Reader.ico 2020-10-30 19:08:48,373[DEBUG]: Powershell command to create shortcut: powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -Command '$ws = New-Object -ComObject WScript.Shell; $s = $ws.CreateShortcut("C:\Users\sursm.config\wsl-windows-toolbar-launcher\menus\WSL\Internet\Mail Reader.lnk");$s.TargetPath = "wscript";$s.Arguments = ""C:\Users\sursm\.config\wsl-windows-toolbar-launcher\metadata\WSL\silent-launcher.vbs" "C:\Users\sursm\.config\wsl-windows-toolbar-launcher\metadata\WSL\Internet\Mail Reader.bat"";$s.Description = "Read your email";$s.WorkingDirectory = "%USERPROFILE%";$s.IconLocation = "C:\Users\sursm.config\wsl-windows-toolbar-launcher\metadata\WSL\Internet\Mail Reader.ico";$s.Save()' 2020-10-30 19:08:48,785[DEBUG]: Created C:\Users\sursm.config\wsl-windows-toolbar-launcher\menus\WSL\Internet\Mail Reader.lnk 2020-10-30 19:08:48,785[INFO]: Creating menu item for: Internet/Web Browser 2020-10-30 19:08:48,800[DEBUG]: Will create shortcut file: /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/menus/WSL/Internet/Web Browser.lnk 2020-10-30 19:08:48,800[DEBUG]: Creating icon files for: web-browser, /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL/Internet/Web Browser [Adwaita] 2020-10-30 19:08:48,869[DEBUG]: Checking with theme: Papirus 2020-10-30 19:08:48,887[DEBUG]: Checking with theme: Humanity 2020-10-30 19:08:48,905[DEBUG]: Found icon path: web-browser for theme Humanity 2020-10-30 19:08:48,905[DEBUG]: Checking with theme: Papirus 2020-10-30 19:08:48,906[DEBUG]: Checking with theme: Humanity 2020-10-30 19:08:48,913[DEBUG]: Found icon path: web-browser for theme Humanity 2020-10-30 19:08:48,915[DEBUG]: Could not convert using python methods - falling back on imagemagick 2020-10-30 19:08:49,122[DEBUG]: Converted /usr/share/icons/Humanity/apps/48/web-browser.svg to /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL/Internet/Web Browser.png using imagemagick 2020-10-30 19:08:49,134[DEBUG]: STREAM b'IHDR' 16 13 2020-10-30 19:08:49,134[DEBUG]: STREAM b'gAMA' 41 4 2020-10-30 19:08:49,135[DEBUG]: STREAM b'cHRM' 57 32 2020-10-30 19:08:49,135[DEBUG]: STREAM b'bKGD' 101 6 2020-10-30 19:08:49,135[DEBUG]: b'bKGD' 101 6 (unknown) 2020-10-30 19:08:49,135[DEBUG]: STREAM b'IDAT' 119 9917 2020-10-30 19:08:49,139[DEBUG]: STREAM b'tEXt' 10048 37 2020-10-30 19:08:49,139[DEBUG]: STREAM b'tEXt' 10097 37 2020-10-30 19:08:49,139[DEBUG]: STREAM b'tEXt' 10146 62 2020-10-30 19:08:49,196[DEBUG]: Successfully created /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL/Internet/Web Browser.ico 2020-10-30 19:08:49,326[DEBUG]: Powershell command to create shortcut: powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -Command '$ws = New-Object -ComObject WScript.Shell; $s = $ws.CreateShortcut("C:\Users\sursm.config\wsl-windows-toolbar-launcher\menus\WSL\Internet\Web Browser.lnk");$s.TargetPath = "wscript";$s.Arguments = ""C:\Users\sursm\.config\wsl-windows-toolbar-launcher\metadata\WSL\silent-launcher.vbs" "C:\Users\sursm\.config\wsl-windows-toolbar-launcher\metadata\WSL\Internet\Web Browser.bat"";$s.Description = "Browse the web";$s.WorkingDirectory = "%USERPROFILE%";$s.IconLocation = "C:\Users\sursm.config\wsl-windows-toolbar-launcher\metadata\WSL\Internet\Web Browser.ico";$s.Save()' 2020-10-30 19:08:49,983[DEBUG]: Created C:\Users\sursm.config\wsl-windows-toolbar-launcher\menus\WSL\Internet\Web Browser.lnk 2020-10-30 19:08:49,984[INFO]: Creating menu item for: Programming/Android Studio 2020-10-30 19:08:50,010[DEBUG]: Will create shortcut file: /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/menus/WSL/Programming/Android Studio.lnk 2020-10-30 19:08:50,010[DEBUG]: Creating icon files for: androidstudio, /mnt/c/Users/sursm/.config/wsl-windows-toolbar-launcher/metadata/WSL/Programming/Android Studio [Adwaita] 2020-10-30 19:08:50,054[DEBUG]: Could not convert using python methods - falling back on imagemagick

fquinner commented 3 years ago

Hi there finally got around to try and recreate this but it seemed to work fine for me. How did you install Android Studio? I did it using the Jetbrains toolbox and it seemed to work ok. There's a chance that the Jetbrains folks have fixed this since the issue was created too?

fquinner commented 3 years ago

OK I stumbled across a repro here while testing other things - this will happen if cairosvg is not found since Imagemagick looks like it hangs and pins CPU. Workaround would be to:

pip install cairosvg
fquinner commented 3 years ago

Looks like this: https://bugs.launchpad.net/ubuntu/+source/imagemagick/+bug/1879001

I didn't see it before because cairo looks like it handles this file fine, but it sounds like it's a common issue with Imagemagick and soms .svg files.

fquinner commented 3 years ago

Timeout added in 0.6.0 thanks for reporting