search

cascornelissen / svg-spritemap-webpack-plugin

SVG spritemap plugin for webpack
MIT License
207 stars 50 forks source link

Raise contenthash length from 16 to 32 characters #150

Closed toooni closed 3 years ago

toooni commented 3 years ago

This would solve this issue: https://github.com/cascornelissen/svg-spritemap-webpack-plugin/issues/149 since https://github.com/shellscape/webpack-manifest-plugin (v3.0.0) by default does only replace hashes which are 32 chars long.

I am not sure what this would mean for BC. If you do not agree with this change, please just close the PR.

cascornelissen commented 3 years ago

Thanks for the contribution, I don't think it will cause issues with regards to backwards compatibility but let's see if this can be improved within webpack-manifest-plugin as explained in https://github.com/cascornelissen/svg-spritemap-webpack-plugin/issues/149#issuecomment-773209601.

cascornelissen commented 3 years ago

Since I'm expecting this will get resolve in webpack-manifest-plugin I'm closing this PR.