search

cascornelissen / svg-spritemap-webpack-plugin

SVG spritemap plugin for webpack
MIT License
207 stars 50 forks source link

HookWebpackError: plugins is not iterable #164

Closed xavierfoucrier closed 3 years ago

xavierfoucrier commented 3 years ago

Hello @cascornelissen,

I have another issue with the latest version of svg-spritemap-webpack-plugin@4.0.1. When you omit the plugins parameter of SVGO 2, webpack throw a HookWebpackError.

Using an empty array for plugins like plugins: [] works.

It should be fine to avoid this parameter if a developer just want to apply a global option, like floatPrecision, and use the default plugins configuration.

Thanks for the feedback! :wink:

You can update/fetch the previous repository I share with you to see the issue.

cascornelissen commented 3 years ago

Thanks for the issue, this should be fixed in a5d1705. Would you mind verifying by installing via GitHub before I create a release and publish it?

npm install cascornelissen/svg-spritemap-webpack-plugin#master
xavierfoucrier commented 3 years ago

@cascornelissen sure, I am on it :wink:

xavierfoucrier commented 3 years ago

@cascornelissen looks like it works fine :+1:

cascornelissen commented 3 years ago

Great, just published 4.0.2 with this fix, thanks once more for reporting! ❤️